Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.4] Mfa::getConfigurationInterface throws error if called from other component #43818

Merged
merged 5 commits into from
Aug 2, 2024
Merged

[4.4] Mfa::getConfigurationInterface throws error if called from other component #43818

merged 5 commits into from
Aug 2, 2024

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Jul 20, 2024 •
edited
Loading

Pull Request for Issue #43812.

Summary of Changes

Fix syntax error throws error.

Testing Instructions

Code review

or

follow instructions #43812

@Quy Quy mentioned this pull request Jul 21, 2024
Closed
@Quy Quy changed the title [4.4] Mfa::getConfigurationInterface thows error if called from other component [4.4] Mfa::getConfigurationInterface throws error if called from other component Jul 21, 2024
@Quy Quy added the bug label Jul 21, 2024
@richard67
Copy link
Member

I have tested this item ✅ successfully on 9db2a10

Code review.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43818.

@OctavianC
Copy link
Contributor

I have tested this item ✅ successfully on 9db2a10

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43818.

@Quy
Copy link
Contributor Author

Quy commented Jul 22, 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43818.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 22, 2024
@MacJoom MacJoom self-assigned this Jul 23, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.7 milestone Aug 2, 2024
@MacJoom MacJoom merged commit 936d1ee into joomla:4.4-dev Aug 2, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 2, 2024
@MacJoom
Copy link
Contributor

MacJoom commented Aug 2, 2024

Thank you!

@Quy Quy deleted the 43812-mfa branch August 2, 2024 13:43
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
@QuyTon @dgrammatiko
Fix syntax (joomla#43818)
ae23ec9
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
@QuyTon @dgrammatiko
Fix syntax (joomla#43818)
12aeae3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MacJoom MacJoom

Labels
bug PR-4.4-dev
Projects
None yet
Milestone
Joomla! 4.4.7
Development

Successfully merging this pull request may close these issues.
6 participants
@Quy @richard67 @OctavianC @MacJoom @joomla-cms-bot @QuyTon